From f27f43899840cc0a51ab9de55a1bdfb90f5d652e Mon Sep 17 00:00:00 2001
From: Christian Basler <chrigu@dissem.ch>
Date: Fri, 22 Sep 2017 20:29:23 +0200
Subject: [PATCH] Minor fixes and improvements

---
 .../java/ch/dissem/apps/abit/MainActivity.kt  | 14 ++---
 .../dissem/apps/abit/MessageDetailFragment.kt | 15 ++----
 .../dissem/apps/abit/MessageListFragment.kt   | 53 ++++++++++---------
 .../dissem/apps/abit/listener/WifiReceiver.kt | 28 +---------
 .../java/ch/dissem/apps/abit/util/FabUtils.kt |  2 +-
 .../ch/dissem/apps/abit/util/Preferences.kt   |  4 +-
 .../layout/dialog_select_message_encoding.xml |  5 +-
 .../main/res/layout/select_identity_row.xml   |  1 -
 app/src/main/res/menu/compose.xml             |  2 +-
 app/src/main/res/values-de/strings.xml        |  3 ++
 app/src/main/res/values/strings.xml           |  1 +
 11 files changed, 51 insertions(+), 77 deletions(-)

diff --git a/app/src/main/java/ch/dissem/apps/abit/MainActivity.kt b/app/src/main/java/ch/dissem/apps/abit/MainActivity.kt
index 677ca79..7734e09 100644
--- a/app/src/main/java/ch/dissem/apps/abit/MainActivity.kt
+++ b/app/src/main/java/ch/dissem/apps/abit/MainActivity.kt
@@ -29,7 +29,6 @@ import ch.dissem.apps.abit.drawer.ProfileImageListener
 import ch.dissem.apps.abit.drawer.ProfileSelectionListener
 import ch.dissem.apps.abit.listener.ListSelectionListener
 import ch.dissem.apps.abit.repository.AndroidMessageRepository.Companion.LABEL_ARCHIVE
-import ch.dissem.apps.abit.service.BitmessageService.Companion.isRunning
 import ch.dissem.apps.abit.service.Singleton
 import ch.dissem.apps.abit.synchronization.SyncAdapter
 import ch.dissem.apps.abit.util.Labels
@@ -99,8 +98,8 @@ class MainActivity : AppCompatActivity(), ListSelectionListener<Serializable> {
     private lateinit var drawer: Drawer
     private lateinit var nodeSwitch: SwitchDrawerItem
 
-    val floatingActionButton: FabSpeedDial
-        get() = fab
+    val floatingActionButton: FabSpeedDial?
+        get() = findViewById(R.id.fab) as FabSpeedDial?
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -359,11 +358,12 @@ class MainActivity : AppCompatActivity(), ListSelectionListener<Serializable> {
     }
 
     override fun onRestoreInstanceState(savedInstanceState: Bundle) {
-        selectedLabel = savedInstanceState.getSerializable("selectedLabel") as Label
+        selectedLabel = savedInstanceState.getSerializable("selectedLabel") as Label?
 
-        val selectedItem = drawer.getDrawerItem(selectedLabel)
-        if (selectedItem != null) {
-            drawer.setSelection(selectedItem)
+        selectedLabel?.let { selectedLabel ->
+            drawer.getDrawerItem(selectedLabel)?.let { selectedItem ->
+                drawer.setSelection(selectedItem)
+            }
         }
         super.onRestoreInstanceState(savedInstanceState)
     }
diff --git a/app/src/main/java/ch/dissem/apps/abit/MessageDetailFragment.kt b/app/src/main/java/ch/dissem/apps/abit/MessageDetailFragment.kt
index c6cb099..2f62832 100644
--- a/app/src/main/java/ch/dissem/apps/abit/MessageDetailFragment.kt
+++ b/app/src/main/java/ch/dissem/apps/abit/MessageDetailFragment.kt
@@ -111,14 +111,7 @@ class MessageDetailFragment : Fragment() {
             text.linksClickable = true
             text.setTextIsSelectable(true)
 
-            var removed = false
-            val labels = item.labels.iterator()
-            while (labels.hasNext()) {
-                if (labels.next().type == Label.Type.UNREAD) {
-                    labels.remove()
-                    removed = true
-                }
-            }
+            val removed = item.labels.removeAll { it.type==Label.Type.UNREAD }
             val messageRepo = Singleton.getMessageRepository(context)
             if (removed) {
                 if (activity is MainActivity) {
@@ -173,15 +166,14 @@ class MessageDetailFragment : Fragment() {
                         Singleton.labeler.delete(item)
                         messageRepo.save(item)
                     }
+                    (activity as? MainActivity)?.updateUnread()
                     activity.onBackPressed()
                     return true
                 }
                 R.id.mark_unread -> {
                     Singleton.labeler.markAsUnread(item)
                     messageRepo.save(item)
-                    if (activity is MainActivity) {
-                        (activity as MainActivity).updateUnread()
-                    }
+                    (activity as? MainActivity)?.updateUnread()
                     return true
                 }
                 R.id.archive -> {
@@ -190,6 +182,7 @@ class MessageDetailFragment : Fragment() {
                     }
                     Singleton.labeler.archive(item)
                     messageRepo.save(item)
+                    (activity as? MainActivity)?.updateUnread()
                     return true
                 }
                 else -> return false
diff --git a/app/src/main/java/ch/dissem/apps/abit/MessageListFragment.kt b/app/src/main/java/ch/dissem/apps/abit/MessageListFragment.kt
index a395751..3e68de5 100644
--- a/app/src/main/java/ch/dissem/apps/abit/MessageListFragment.kt
+++ b/app/src/main/java/ch/dissem/apps/abit/MessageListFragment.kt
@@ -16,9 +16,8 @@
 
 package ch.dissem.apps.abit
 
+
 import android.content.Intent
-
-
 import android.os.Bundle
 import android.support.v4.app.Fragment
 import android.support.v4.content.ContextCompat
@@ -32,7 +31,6 @@ import ch.dissem.apps.abit.ComposeMessageActivity.Companion.EXTRA_IDENTITY
 import ch.dissem.apps.abit.adapter.SwipeableMessageAdapter
 import ch.dissem.apps.abit.listener.ListSelectionListener
 import ch.dissem.apps.abit.repository.AndroidMessageRepository
-import ch.dissem.apps.abit.repository.AndroidMessageRepository.Companion.LABEL_ARCHIVE
 import ch.dissem.apps.abit.service.Singleton
 import ch.dissem.apps.abit.util.FabUtils
 import ch.dissem.bitmessage.entity.Plaintext
@@ -186,18 +184,17 @@ class MessageListFragment : Fragment(), ListHolder<Label> {
         adapter.eventListener = object : SwipeableMessageAdapter.EventListener {
             override fun onItemDeleted(item: Plaintext) {
                 if (MessageDetailFragment.isInTrash(item)) {
+                    Singleton.labeler.delete(item)
                     messageRepo.remove(item)
                 } else {
-                    item.labels.clear()
-                    item.addLabels(messageRepo.getLabels(Label.Type.TRASH))
+                    Singleton.labeler.delete(item)
                     messageRepo.save(item)
                 }
                 recyclerViewOnScrollListener.onScrolled(null, 0, 0)
             }
 
             override fun onItemArchived(item: Plaintext) {
-                item.labels.clear()
-                messageRepo.save(item)
+                Singleton.labeler.archive(item)
                 recyclerViewOnScrollListener.onScrolled(null, 0, 0)
             }
 
@@ -242,19 +239,29 @@ class MessageListFragment : Fragment(), ListHolder<Label> {
         this.swipeableMessageAdapter = adapter
 
         Singleton.labeler.listener = { message, added, removed ->
-            if (currentLabel?.type == Label.Type.TRASH && added.all { it.type == Label.Type.TRASH } && removed.isEmpty()) {
-                // work-around for messages that are deleted from trash
-                swipeableMessageAdapter?.remove(message)
-                recyclerViewOnScrollListener.onScrolled(null, 0, 0)
-            } else if (added.contains(currentLabel)) {
-                // in most cases, top should be the correct position, but time will show if
-                // the message should be properly sorted in
-                swipeableMessageAdapter?.addFirst(message)
-            } else if (removed.contains(currentLabel)) {
-                swipeableMessageAdapter?.remove(message)
-                recyclerViewOnScrollListener.onScrolled(null, 0, 0)
-            } else if (removed.any { it.type == Label.Type.UNREAD } || added.any { it.type == Label.Type.UNREAD }) {
-                swipeableMessageAdapter?.update(message)
+            when {
+                currentLabel?.type == Label.Type.TRASH && added.all { it.type == Label.Type.TRASH } && removed.any { it.type == Label.Type.TRASH } -> {
+                    // work-around for messages that are deleted from trash
+                    swipeableMessageAdapter?.remove(message)
+                    recyclerViewOnScrollListener.onScrolled(null, 0, 0)
+                }
+                currentLabel?.type == Label.Type.UNREAD && added.all { it.type == Label.Type.TRASH } -> {
+                    // work-around for messages that are deleted from unread, which already have the unread label removed
+                    swipeableMessageAdapter?.remove(message)
+                    recyclerViewOnScrollListener.onScrolled(null, 0, 0)
+                }
+                added.contains(currentLabel) -> {
+                    // in most cases, top should be the correct position, but time will show if
+                    // the message should be properly sorted in
+                    swipeableMessageAdapter?.addFirst(message)
+                }
+                removed.contains(currentLabel) -> {
+                    swipeableMessageAdapter?.remove(message)
+                    recyclerViewOnScrollListener.onScrolled(null, 0, 0)
+                }
+                removed.any { it.type == Label.Type.UNREAD } || added.any { it.type == Label.Type.UNREAD } -> {
+                    swipeableMessageAdapter?.update(message)
+                }
             }
         }
     }
@@ -348,10 +355,4 @@ class MessageListFragment : Fragment(), ListHolder<Label> {
             true
         }
     }
-
-    fun addMessage(message: Plaintext) {
-        if (message.labels.contains(currentLabel) || (currentLabel == LABEL_ARCHIVE && message.labels.isEmpty())) {
-            swipeableMessageAdapter?.addFirst(message)
-        }
-    }
 }
diff --git a/app/src/main/java/ch/dissem/apps/abit/listener/WifiReceiver.kt b/app/src/main/java/ch/dissem/apps/abit/listener/WifiReceiver.kt
index fbd61fc..7171483 100644
--- a/app/src/main/java/ch/dissem/apps/abit/listener/WifiReceiver.kt
+++ b/app/src/main/java/ch/dissem/apps/abit/listener/WifiReceiver.kt
@@ -19,42 +19,18 @@ package ch.dissem.apps.abit.listener
 import android.content.BroadcastReceiver
 import android.content.Context
 import android.content.Intent
-import android.net.ConnectivityManager
-import android.net.NetworkInfo
 import ch.dissem.apps.abit.service.BitmessageService
 import ch.dissem.apps.abit.service.Singleton
 import ch.dissem.apps.abit.util.Preferences
+import org.jetbrains.anko.connectivityManager
 
 class WifiReceiver : BroadcastReceiver() {
     override fun onReceive(ctx: Context, intent: Intent) {
         if ("android.net.conn.CONNECTIVITY_CHANGE" == intent.action) {
             val bmc = Singleton.getBitmessageContext(ctx)
-            if (Preferences.isWifiOnly(ctx) && isConnectedToMeteredNetwork(ctx) && bmc.isRunning()) {
-                bmc.shutdown()
-            }
-            if (Preferences.isFullNodeActive(ctx) && !bmc.isRunning() && !(Preferences.isWifiOnly(ctx) && isConnectedToMeteredNetwork(ctx))) {
+            if (Preferences.isFullNodeActive(ctx) && !bmc.isRunning() && !(Preferences.isWifiOnly(ctx) && ctx.connectivityManager.isActiveNetworkMetered)) {
                 ctx.startService(Intent(ctx, BitmessageService::class.java))
             }
         }
     }
-
-    companion object {
-
-        fun isConnectedToMeteredNetwork(ctx: Context): Boolean {
-            val netInfo = getNetworkInfo(ctx)
-            if (netInfo == null || !netInfo.isConnectedOrConnecting) {
-                return false
-            }
-            when (netInfo.type) {
-                ConnectivityManager.TYPE_ETHERNET, ConnectivityManager.TYPE_WIFI -> return false
-                else -> return true
-            }
-        }
-
-        private fun getNetworkInfo(ctx: Context): NetworkInfo? {
-            val conMan = ctx.getSystemService(Context
-                    .CONNECTIVITY_SERVICE) as ConnectivityManager
-            return conMan.activeNetworkInfo
-        }
-    }
 }
diff --git a/app/src/main/java/ch/dissem/apps/abit/util/FabUtils.kt b/app/src/main/java/ch/dissem/apps/abit/util/FabUtils.kt
index bc890f7..93647b4 100644
--- a/app/src/main/java/ch/dissem/apps/abit/util/FabUtils.kt
+++ b/app/src/main/java/ch/dissem/apps/abit/util/FabUtils.kt
@@ -11,7 +11,7 @@ import io.github.kobakei.materialfabspeeddial.FabSpeedDialMenu
  */
 object FabUtils {
     fun initFab(activity: MainActivity, @DrawableRes drawableRes: Int, menu: FabSpeedDialMenu): FabSpeedDial {
-        val fab = activity.floatingActionButton
+        val fab = activity.floatingActionButton ?: throw IllegalStateException("Fab must not be null")
         fab.removeAllOnMenuItemClickListeners()
         fab.show()
         fab.closeMenu()
diff --git a/app/src/main/java/ch/dissem/apps/abit/util/Preferences.kt b/app/src/main/java/ch/dissem/apps/abit/util/Preferences.kt
index 91cf57e..de71277 100644
--- a/app/src/main/java/ch/dissem/apps/abit/util/Preferences.kt
+++ b/app/src/main/java/ch/dissem/apps/abit/util/Preferences.kt
@@ -26,6 +26,8 @@ import ch.dissem.apps.abit.util.Constants.PREFERENCE_REQUEST_ACK
 import ch.dissem.apps.abit.util.Constants.PREFERENCE_SYNC_TIMEOUT
 import ch.dissem.apps.abit.util.Constants.PREFERENCE_TRUSTED_NODE
 import ch.dissem.apps.abit.util.Constants.PREFERENCE_WIFI_ONLY
+import org.jetbrains.anko.connectivityManager
+import org.jetbrains.anko.networkStatsManager
 import org.slf4j.LoggerFactory
 import java.io.File
 import java.io.IOException
@@ -88,7 +90,7 @@ object Preferences {
         return preferences.getString(name, null)
     }
 
-    fun isConnectionAllowed(ctx: Context) = !isWifiOnly(ctx) || !WifiReceiver.isConnectedToMeteredNetwork(ctx)
+    fun isConnectionAllowed(ctx: Context) = !isWifiOnly(ctx) || ctx.connectivityManager.isActiveNetworkMetered
 
     fun isWifiOnly(ctx: Context): Boolean {
         val preferences = PreferenceManager.getDefaultSharedPreferences(ctx)
diff --git a/app/src/main/res/layout/dialog_select_message_encoding.xml b/app/src/main/res/layout/dialog_select_message_encoding.xml
index 02dcab0..f9bef0f 100644
--- a/app/src/main/res/layout/dialog_select_message_encoding.xml
+++ b/app/src/main/res/layout/dialog_select_message_encoding.xml
@@ -18,7 +18,6 @@
 <RelativeLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:paddingBottom="18dp"
@@ -71,7 +70,7 @@
         android:text="@string/ok"
         android:textColor="@color/colorAccent"
         app:layout_constraintHorizontal_bias="1.0"
-        android:layout_alignRight="@+id/radioGroup"
+        android:layout_alignEnd="@+id/radioGroup"
         android:layout_below="@+id/radioGroup"/>
 
     <Button
@@ -81,7 +80,7 @@
         android:layout_height="wrap_content"
         android:text="@string/cancel"
         android:textColor="@color/colorAccent"
-        android:layout_toLeftOf="@+id/ok"
+        android:layout_toStartOf="@+id/ok"
         android:layout_below="@+id/radioGroup"/>
 
 </RelativeLayout>
diff --git a/app/src/main/res/layout/select_identity_row.xml b/app/src/main/res/layout/select_identity_row.xml
index 8324c5f..b65cce1 100644
--- a/app/src/main/res/layout/select_identity_row.xml
+++ b/app/src/main/res/layout/select_identity_row.xml
@@ -31,7 +31,6 @@
         android:paddingEnd="8dp"
         android:paddingStart="16dp"
         android:paddingTop="8dp"
-        android:text="CheckBox"
         android:textAppearance="?android:attr/textAppearanceMedium"
         tools:text="Name"/>
 
diff --git a/app/src/main/res/menu/compose.xml b/app/src/main/res/menu/compose.xml
index b6aafb2..aebde7c 100644
--- a/app/src/main/res/menu/compose.xml
+++ b/app/src/main/res/menu/compose.xml
@@ -10,6 +10,6 @@
         android:id="@+id/select_encoding"
         app:showAsAction="never"
         android:icon="@drawable/ic_action_encoding"
-        android:title="Select encoding"
+        android:title="@string/select_encoding"
         />
 </menu>
diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml
index e78784e..1b7d37c 100644
--- a/app/src/main/res/values-de/strings.xml
+++ b/app/src/main/res/values-de/strings.xml
@@ -124,4 +124,7 @@ Als Alternative kann in den Einstellungen ein vertrauenswürdiger Knoten konfigu
     <string name="request_acknowledgements">Bestätigungen verlangen</string>
     <string name="request_acknowledgements_summary">Bestätigungen stellen sicher dass eine Nachricht empfangen wurde, benötigen aber zusätzliche Zeit zum versenden</string>
     <string name="got_it">Alles klar</string>
+    <string name="import_data">Import</string>
+    <string name="import_data_summary">Nachrichten und Kontakte importieren (aber keine Identitäten)</string>
+    <string name="select_encoding">Kodierung auswählen</string>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index e165568..8e4a692 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -125,4 +125,5 @@ As an alternative you could configure a trusted node in the settings, but as of
     <string name="request_acknowledgements">Request acknowledgements</string>
     <string name="request_acknowledgements_summary">Acknowledges allow making sure a message was received, but require additional time to send</string>
     <string name="got_it">Got it</string>
+    <string name="select_encoding">Select encoding</string>
 </resources>